Fixes for graphics_pipeline benchmark wireframe mode and 1x1 texture mode #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ran for helping debug this! |
my pleasure :) |
angela28chen
force-pushed
the
fix-benchmark
branch
from
490ff4e
to
27ecc79
Compare
wangra-google
approved these changes
Feb 14, 2024
apazylbe
approved these changes
Feb 14, 2024
|
Oops, fixed the PR description! |
apazylbe
approved these changes
Feb 15, 2024
GrantComm
pushed a commit
to GrantComm/bigwheels
that referenced
this pull request
Mar 20, 2024
…mode (google#433) Fixes: - google#432 Adding WaitIdle() before sphere descriptors are updated - google#423 Setting fillModeNonSolid to true for all applications to allow use of VK_POLYGON_MODE_LINE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: