Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Vulkan Validation errors #441

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fixes for Vulkan Validation errors #441

merged 1 commit into from
Mar 5, 2024

Conversation

angela28chen
Copy link
Collaborator

  • VUID-VkShaderModuleCreateInfo-pCode-08742 : Needs to be checked by messageIdName and not messageIdNumber
  • VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext : Need extension VK_EXT_depth_clip_enable rather than VK_EXT_depth_range_unrestricted
@angela28chen
Fixes for Vulkan Validation errors:
711b4d0 
* VUID-VkShaderModuleCreateInfo-pCode-08742 : Needs to be checked by messageIdName and not messageIdNumber
* VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext : Need extension VK_EXT_depth_clip_enable rather than VK_EXT_depth_range_unrestricted
apazylbe
apazylbe approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@apazylbe apazylbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@apazylbe apazylbe merged commit 9427c6e into google:main Mar 5, 2024
5 checks passed
GrantComm pushed a commit to GrantComm/bigwheels that referenced this pull request Mar 20, 2024
@angela28chen @GrantComm
Fixes for Vulkan Validation errors (google#441)
de5b4a8 
* VUID-VkShaderModuleCreateInfo-pCode-08742 : Needs to be checked by
messageIdName and not messageIdNumber
* VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext : Need
extension VK_EXT_depth_clip_enable rather than
VK_EXT_depth_range_unrestricted
GrantComm pushed a commit to GrantComm/bigwheels that referenced this pull request Apr 25, 2024
@angela28chen @GrantComm
Fixes for Vulkan Validation errors (google#441)
e3c9f6e 
* VUID-VkShaderModuleCreateInfo-pCode-08742 : Needs to be checked by
messageIdName and not messageIdNumber
* VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext : Need
extension VK_EXT_depth_clip_enable rather than
VK_EXT_depth_range_unrestricted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@angela28chen @apazylbe @wangra-google