Add support for partial bindings (vk only) #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apazylbe
reviewed
Mar 13, 2024
anishmgoyal
force-pushed
the
addPartialBindings
branch
4 times, most recently
from
cc77f82
to
ce0f8e1
Compare
Keenuts
reviewed
Mar 14, 2024
apazylbe
reviewed
Mar 14, 2024
apazylbe
reviewed
Mar 14, 2024
DX12 support may be added later. Adds supports for partially bound descriptors, which allows us to create arrays for textures where only a subset of the allotted slots are used.
When binding flags are set, check for support and warn users before adding structs to the call. Also, only add the flags struct if there are non-zero flags, to ensure we don't break use-cases where the device doesn't support descriptor indexing features.
Also: simplify some validation logic.
anishmgoyal
force-pushed
the
addPartialBindings
branch
from
19814e0
to
8393a97
Compare
apazylbe
approved these changes
Mar 18, 2024
Don't check for runtimeDescriptorArrays when checking for partial binding support. Also, log when partial binding is enabled in DirectX, because we haven't confirmed that this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DX12 support may be added later. Adds supports for partially bound descriptors, which allows us to create arrays for textures where only a subset of the allotted slots are used.