Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for YCBCR conversions #450

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add support for YCBCR conversions #450

merged 3 commits into from
Apr 16, 2024

Conversation

anishmgoyal
Copy link
Collaborator

Add grfx support for YCBCR conversions, and pipe this into relevant APIs on the Vulkan side. On DX12, log and return errors when attempting to use YCBCR conversion, as it is not supported.

Note: this change does not include the addition of YCBCR file types / planar file loading. That will be added in a follow-up PR.
@anishmgoyal anishmgoyal force-pushed the addYuvSupport branch 3 times, most recently from 8af4b61 to ff7547a Compare April 4, 2024 19:57
@apazylbe apazylbe requested a review from Keenuts April 4, 2024 20:33
Keenuts
Keenuts approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my end. @apazylbe you can merge if you also approve
apazylbe
apazylbe reviewed Apr 8, 2024
View reviewed changes
include/ppx/graphics_util.h Outdated Show resolved Hide resolved
include/ppx/grfx/grfx_image.h Outdated Show resolved Hide resolved
include/ppx/grfx/grfx_image.h Outdated Show resolved Hide resolved
include/ppx/grfx/grfx_image.h Outdated Show resolved Hide resolved
include/ppx/grfx/grfx_texture.h Outdated Show resolved Hide resolved
include/ppx/grfx/grfx_config.h Outdated Show resolved Hide resolved
apazylbe
apazylbe approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@apazylbe apazylbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering renaming YcbcrConversion to SampleYcbcrConversion (up to you), otherwise lgtm. Thanks!
@anishmgoyal
Add support for YCBCR conversions
3c28f33 
Add grfx support for YCBCR conversions, and pipe this into relevant APIs
on the Vulkan side. On DX12, log and return errors when attempting to
use YCBCR conversion, as it is not supported.

Note: this change does not include the addition of YCBCR file types /
planar file loading. That will be added in a follow-up PR.
@anishmgoyal
Address PR comments
0279510 
Naming convention for pointers, comment-style convention
@anishmgoyal
Rename YcbcrConversion -> SamplerYcbcrConversion
d80c452 
Addresses PR comment, makes the name match the Vulkan API name for
consistency.
@anishmgoyal anishmgoyal enabled auto-merge (squash) April 16, 2024 18:45
@anishmgoyal anishmgoyal merged commit c7a4e66 into google:main Apr 16, 2024
5 checks passed
@anishmgoyal anishmgoyal deleted the addYuvSupport branch April 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@anishmgoyal @Keenuts @apazylbe