Update mViewProjectionMatrix in ArcballCamera::UpdateCamera #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
footballhead
force-pushed
the
topic/arcball_fix
branch
from
3e29e6d
to
ea5c34a
Compare
apazylbe
approved these changes
Apr 17, 2024
I added an ArcballCamera to google#428 and noticed that it wasn't working as expected. ArcballCamera wasn't updating mViewProjectionMatrix after modifying mViewMatrix. This was causing the ArcballCamera to not work correctly when combined with the classes introduced in google#426.
apazylbe
force-pushed
the
topic/arcball_fix
branch
from
ea5c34a
to
859f682
Compare
Keenuts
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an ArcballCamera to #428 and noticed that it wasn't working as expected.
ArcballCamera wasn't updating
mViewProjectionMatrixafter modifyingmViewMatrix. This was causing the ArcballCamera to not work correctly when combined with the classes introduced in #426.