Use LOAD_OP_LOAD for DSV in swapchain load render pass #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create convenience render passes that write to swapchain images. One set with LOAD_OP_CLEAR and one with LOAD_OP_LOAD. Previously LOAD_OP_LOAD render passes used LOAD_OP_CLEAR for depth stencil attachment, now we will use LOAD_OP_LOAD. Tested by modifying dynamic rendering sample to use regular render passes. Fixes google#467
Keenuts
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create convenience render passes that write to swapchain images. One set with LOAD_OP_CLEAR and one with LOAD_OP_LOAD. Previously LOAD_OP_LOAD render passes used LOAD_OP_CLEAR for depth stencil attachment, now we will use LOAD_OP_LOAD.
Tested by modifying dynamic rendering sample to use regular render passes.
Fixes #467