Replace ALooper_pollAll with ALooper_pollOnce #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is sourced from a downstream patch. The incoming NDK r27 removes `ALooper_pollAll` as it can't be called safely. See android/ndk#2020 for more context. While this change strives to introduce as little behavior change as possible, Some behavior changes might be happening. 1. We are failing more explicitly when `ALooper_pollOnce` returns `ALOOPER_POLL_ERROR`. When this error is returned, there is no point in retrying polling in the current thread. 2. Compared with `ALooper_pollAll`, `ALooper_pollOnce` can return more frequently with `ALOOPER_POLL_CALLBACK`. This can lead to "on_idle" logic being executed more frequently. Co-Authored-By: google-yfyang <yfyang@google.com> Signed-off-by: Nathan Gauër <brioche@google.com>
apazylbe
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is sourced from a downstream patch.
The incoming NDK r27 removes
ALooper_pollAllas it can't be called safely.See android/ndk#2020 for more context.
While this change strives to introduce as little behavior change as possible, Some behavior changes might be happening.
ALooper_pollOncereturnsALOOPER_POLL_ERROR. When this error is returned, there is no point in retrying polling in the current thread.ALooper_pollAll,ALooper_pollOncecan return more frequently withALOOPER_POLL_CALLBACK. This can lead to "on_idle" logic being executed more frequently.