Remove debug capture setting #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove debug capture option, tools like RenderDoc can capture directly, and it makes code more complicated. Also use IsXrEnabled instead of settings.xr.enable, that way we can switch how that is controled in the function. Fixes google#464
apazylbe
force-pushed
the
remove_debug_capture
branch
from
dbfc994
to
0afa812
Compare
Keenuts
approved these changes
Jun 13, 2024
|
Thanks! |
apazylbe
added a commit
to apazylbe/bigwheels
that referenced
this pull request
Jun 14, 2024
Missed in google#481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove debug capture option, tools like RenderDoc can capture directly, and it makes code more complicated.
Also use IsXrEnabled instead of settings.xr.enable, that way we can switch how that is controled in the function.
Fixes #464