-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add util functions to fill foveation pattern bitmaps #485
Conversation
Thanks Jorge! Any chance we can split this into separate PRs for each commit/meaningful change instead? This much code is a bit daunting to review. |
7ec0559
to
870b6c6
Compare
I have split the PR into the original commits. |
Since you already have this in separate commits, would it be possible to split into PRs? |
870b6c6
to
c823cbc
Compare
I follows Aliya's advice, I update this PR to contain only one of the CL in the original merge. |
Thanks Jorge for taking care of merging these. I don't remember exactly what benchmarking you're planning to do, so I just want to make sure these functions are actually needed. I added them specifically to test FDM and VRS independent of OpenXR foveation. These let the application use it's own density patterns. In normal OpenXR foveation, the foveation pattern comes from OpenXR, via the application via |
Hi Benson,
To answer the other part of your your comment, I want fixed foveated rendering as a first step. So, if I am able to set a fix pattern of two concentric elipses manually, that will be perfect for my use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! lgtm, just a few comments. Also could you update the PR title and description?
c823cbc
to
090bbf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
By the way, if possible, next time it would be great to address review feedback in separate commits https://github.com/google/bigwheels/blob/main/CONTRIBUTING.md#for-developers-contributing-a-patch
090bbf2
to
7ba6bbe
Compare
7ba6bbe
to
e25a42d
Compare
The first of a series of CL that integrates the commits from:
https://github.com/bjoeris/bigwheels/tree/experimental-foveation
into BW main's branch.
The series will have 4 CL, this is the first ona that integrates the following commit