Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update agile_classifiers.ipynb #481

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update agile_classifiers.ipynb #481

merged 1 commit into from
Jul 10, 2024

Conversation

owahltinez
Copy link
Member

Description of the change

Update codelab based on user feedback

Motivation

Raise an error when words map to unknown tokens and use the score function

Type of change

Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.
@owahltinez owahltinez requested a review from a team as a code owner July 4, 2024 01:50
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Jul 4, 2024
@owahltinez
Copy link
Member Author

Note: the linter is complaining about the use of "we" instead of "you" but the only "we" found in the notebook is from the sample data.
@pcoet pcoet merged commit 8f66c93 into google:main Jul 10, 2024
4 of 5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:documentation Update docs
3 participants
@owahltinez @pcoet @xevilads