Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of GHA CI script for Myanmar tools #70

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

gnrunge
Copy link
Collaborator

@gnrunge gnrunge commented Mar 12, 2021

Migrated selected tasks from Travis CI.

@gnrunge gnrunge requested review from echeran and sffc March 13, 2021 00:05
Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I listed some suggestions for the job IDs. The job names are where we can put longer descriptions, but I think it's nice to have short IDs.

.github/workflows/mynmr_tools_ci.yml Outdated Show resolved Hide resolved
.github/workflows/mynmr_tools_ci.yml Outdated Show resolved Hide resolved
.github/workflows/mynmr_tools_ci.yml Outdated Show resolved Hide resolved
.github/workflows/mynmr_tools_ci.yml Outdated Show resolved Hide resolved
@echeran
Copy link
Collaborator

echeran commented Mar 13, 2021

Looks good so far. Assuming that you're going top-to-bottom in .travis.yml when converting to the Github Actions workflow, it looks like you skipped over the C++ client job (that theoretically might go between the genconvert and java jobs). Is that intentional?

Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to start, and I filed #71 to finish migrating the rest of the targets (which are all important).

Ticket: google#71

Issue 70: Work in review comments.

MT-71 More review comments.
@gnrunge
Copy link
Collaborator Author

gnrunge commented Mar 15, 2021 via email

@gnrunge gnrunge merged commit 0bcfab5 into google:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants