Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add storage utilization gib per node for autoscaling #1317

Merged
merged 5 commits into from
Jul 22, 2022
Merged

feat: add storage utilization gib per node for autoscaling #1317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c61869e
feat: add storage utilization gib per node option for autoscaling
kolea2 Jul 1, 2022
b39a753
add additional assertion
kolea2 Jul 19, 2022
c61ceca
add additional tests
kolea2 Jul 20, 2022
bd72c76
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 20, 2022
033bb6c
review comments
kolea2 Jul 20, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review comments
  • Loading branch information
@kolea2
kolea2 committed Jul 20, 2022
commit 033bb6c2c28fd0225fa5387f2c00623640671875
7 changes: 1 addition & 6 deletions ...igtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,12 +523,7 @@ public Cluster createCluster(CreateClusterRequest request) {
public ApiFuture<Cluster> createClusterAsync(CreateClusterRequest request) {
return ApiFutures.transform(
stub.createClusterOperationCallable().futureCall(request.toProto(projectId)),
new ApiFunction<com.google.bigtable.admin.v2.Cluster, Cluster>() {
@Override
public Cluster apply(com.google.bigtable.admin.v2.Cluster proto) {
return Cluster.fromProto(proto);
}
},
Cluster::fromProto,
MoreExecutors.directExecutor());
}

Expand Down
2 changes: 1 addition & 1 deletion ...igtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateClusterRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public CreateClusterRequest setScalingMode(@Nonnull StaticClusterSize staticClus

/**
* Sets the scaling mode to autoscaling by accepting an AutoscalingConfig where min nodes, max
* nodes, and CPU utlization percent target are set.
* nodes, CPU utilization percent target, and storage utilization gib per node are set.
*/
public CreateClusterRequest setScalingMode(@Nonnull ClusterAutoscalingConfig autoscalingConfig) {
int minNodes = autoscalingConfig.getMinNodes();
Expand Down