Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle retry info so client respect the delay server sets #2026

Merged
merged 14 commits into from
Dec 19, 2023
Merged

feat: handle retry info so client respect the delay server sets #2026

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
11c5a24
feat: add a flag to add / remove routing cookie from callable chain
mutianf Dec 16, 2023
cd0996d
refactor
mutianf Dec 18, 2023
82f5cd7
mark as beta api
mutianf Dec 18, 2023
2b700b0
add a test for initial metadata
mutianf Dec 18, 2023
bec1f11
feat: handle retry info so client respect the delay server sets
mutianf Nov 21, 2023
eb0148f
fix conformance test
mutianf Dec 15, 2023
944a93f
remove unused class
mutianf Dec 15, 2023
5f6d583
address comments
mutianf Dec 17, 2023
a3ef1d1
add a flag for retry info and tests
mutianf Dec 17, 2023
cb519de
Merge branch 'main' into retry_info
mutianf Dec 18, 2023
8a92dfd
format
mutianf Dec 18, 2023
99c43c5
address comments
mutianf Dec 19, 2023
cf00661
fix format
mutianf Dec 19, 2023
06b3a18
rename ApiException
mutianf Dec 19, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rename ApiException
  • Loading branch information
@mutianf
mutianf committed Dec 19, 2023
commit 06b3a189b731c0f717e866154fe7e638b31719b3
5 changes: 4 additions & 1 deletion google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@
<artifactId>grpc-alts</artifactId>
<scope>runtime</scope>
</dependency>
<!-- Runtime dependencies for credentials -->
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
</dependency><!-- Runtime dependencies for credentials -->
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions ...ain/java/com/google/cloud/bigtable/data/v2/stub/mutaterows/MutateRowsAttemptCallable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import com.google.bigtable.v2.MutateRowsResponse.Entry;
import com.google.cloud.bigtable.data.v2.models.MutateRowsException;
import com.google.cloud.bigtable.data.v2.models.MutateRowsException.FailedMutation;
import com.google.cloud.bigtable.gaxx.retrying.ApiExceptions;
import com.google.cloud.bigtable.gaxx.retrying.NonCancellableFuture;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -235,8 +236,7 @@ private void handleAttemptError(Throwable rpcError) {
FailedMutation failedMutation = FailedMutation.create(origIndex, entryError);
allFailures.add(failedMutation);

if (!com.google.cloud.bigtable.gaxx.retrying.ApiException.isRetryable2(
failedMutation.getError())
if (!ApiExceptions.isRetryable2(failedMutation.getError())
&& !failedMutation.getError().isRetryable()) {
permanentFailures.add(failedMutation);
} else {
Expand Down
4 changes: 2 additions & 2 deletions .../bigtable/gaxx/retrying/ApiException.java → ...bigtable/gaxx/retrying/ApiExceptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

// TODO: move this to gax later
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a plan for when we're moving this to gax?
@InternalApi
public class ApiException {
public class ApiExceptions {

private ApiException() {}
private ApiExceptions() {}

// TODO: this should replace the existing ApiException#isRetryable() method,
// but that cant be done in bigtable, so this lives here for now.
Expand Down
Loading