Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix async filter sample tests #976

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jun 3, 2024

Previously, sample CI was failing due to some lint issues, and some bugs in the filter sample tests and dependencies

@daniel-sanche daniel-sanche requested review from a team as code owners June 3, 2024 22:40
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 3, 2024
@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Jun 3, 2024
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 3, 2024
@igorbernstein2 igorbernstein2 merged commit e46f037 into main Jun 4, 2024
25 of 32 checks passed
@igorbernstein2 igorbernstein2 deleted the fix_samples branch June 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: m Pull request size is medium.
3 participants