Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement secret manager datasource #99

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ichbinfrog
Copy link

Implements the secret manager version datasource:

data "google-compute-secret-manager" "test" {
  project = "my-secret"
  name = "my-project"
  version = "1"
}

This implementation is similar to the suggested reference, however stripped down to the bare minimum (no json key decoding).

This is my first PR to this repo, so I have a few open questions:

  • Since I don't see many acceptance tests in the repo, I've only implemented unit tests. I'm open to implementing it if anyone can give me an example / model to follow.

  • Is there a way to "ignore" certain field in the doc generation? The mock field is not particularly useful for the enduser but mandatory (to my knowledge) to pass extra client options for unit tests.

Closes #29

Signed-off-by: Trung <trung.hoang@pricehubble.com>
Signed-off-by: Trung <trung.hoang@pricehubble.com>
Signed-off-by: Trung <trung.hoang@pricehubble.com>
@ichbinfrog ichbinfrog requested a review from a team as a code owner June 19, 2022 15:41
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 19, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Trung <trung.hoang@pricehubble.com>
@nywilken
Copy link
Member

Hi @ichbinfrog apologies for the longer then normal review process. We haven't had the chance to prioritize this review. We have however selected the PR and will provide feedback if you are still interested in working on the change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants