Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Apple Source missing attribute #567

Open
chicman opened this issue Jun 6, 2024 · 1 comment
Open

Convert to Apple Source missing attribute #567

chicman opened this issue Jun 6, 2024 · 1 comment
Labels

Comments

@chicman
Copy link

chicman commented Jun 6, 2024

I was converting some Stardict to AppleSource. I found "info.plist", the CFBundleIdentifier is missing.

According to Apple Document, this is critical for the Application to ID each dictionary. Here is part of the doc.

`[2-6] Info.plist

Edit each value of the followings in the Info.plist
If you use different file name for this plist, you need to edit the variable 'PLIST_PATH' for it in Makefile.

<key>CFBundleDevelopmentRegion</key>
<string>English</string>
<key>CFBundleDisplayName</key>
<string>My Dictionary</string>
<key>CFBundleIdentifier</key>
<string>com.your_company.dictionary.MySample</string>

`

I've tested, if any of the dictionary has the CFBundleIdentifier filled empty, when the search have results in multiple dicts, it will be blank in "all" tab. Result tabs for each dictionary will also not in place.

I think it is better if the converting would combine some string + numbers to generate a unique value as ID. Solves the problem!

@ilius
Copy link
Owner

ilius commented Jun 16, 2024

I pushed a fix.
Please try again.

@ilius ilius added the Bug label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants