Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise syntax error on invalid unicode escape sequences #5146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raise syntax error on invalid unicode escape sequences #5146

wants to merge 1 commit into from

Conversation

matetokodi
Copy link
Contributor

Raise syntax error on invalid unicode escape sequences instead of failing with an assertion

The parser context was required for raising the error, which had to be added to all functions that can call lexer_unchecked_hex_to_character.

This fixes #5134
@zherczeg
Copy link
Member

This patch adds a lot of extra operations. I am thinking why this was not needed before, how we handled this in other cases.
@matetokodi
Raise parser error on invalid unicode escape sequence
025596a 
JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@matetokodi @zherczeg