Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

widgets/page.dialog: Remove function close() and modify "Back" button to have data-rel="back" #6609

Closed
gabrielschulhof opened this issue Oct 15, 2013 · 1 comment
Closed

widgets/page.dialog: Remove function close() and modify "Back" button to have data-rel="back" #6609

gabrielschulhof opened this issue Oct 15, 2013 · 1 comment
Assignees
@arschmitz
Labels
Fixed
Milestone
1.4.0

Comments

@gabrielschulhof
Copy link

Also, please remove the "role" attribute from the anchor providing the "Back" functionality.

This will get rid of the code duplication between the close() method and the pagecontainer's back() method.
@ghost ghost assigned arschmitz Oct 15, 2013
@gabrielschulhof
Copy link
Author

Please also remove _isCloseable: false from the $.extend call in _create, because it's not used anymore.
arschmitz added a commit that referenced this issue Nov 18, 2013
@arschmitz @gseguin
Page.dialog: remove close function and isClosable prop use regular ba…
0601e47 
…ck button Fixes #6609 - widgets/page.dialog: Remove function close() and modify "Back" button to have data-rel="back"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed
2 participants
@arschmitz @gabrielschulhof