Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Non-minified 1.4.0 rc1 fails to load in IE7 #6703

Closed
srgstm opened this issue Nov 6, 2013 · 5 comments
Closed

Non-minified 1.4.0 rc1 fails to load in IE7 #6703

srgstm opened this issue Nov 6, 2013 · 5 comments
Assignees
Milestone

Comments

@srgstm
Copy link

srgstm commented Nov 6, 2013

When loading jquery.mobile-1.4.0-rc.1.js in IE7, it fails with an error:

SCRIPT1028: Expected identifier, string or number
jquery.mobile-1.4.0-rc.1.js, line 6903 character 2

options: $.extend( {
enhanced: false,
}, $.mobile.collapsible.defaults ),

Apparently, it doesn't like the comma after "false".
The trailing comma in object literals was not allowed in the ES3 spec.

@jaspermdegroot
Copy link
Contributor

Interesting. IE7 shouldn't pass support tests because it is C-grade as from 1.4.

@srgstm
Copy link
Author

srgstm commented Nov 9, 2013

С-grade is described by jQuery Mobile as "Basic, non-enhanced HTML experience that is still functional".
Still_Functional != Non_Functional. BTW, a minified version (which removes the extra comma automatically) IS functional!

@jaspermdegroot
Copy link
Contributor

@srgstm

I know it still has to be functional, so I didn't mean that it isn't a bug.

@gabrielschulhof
Copy link

I'm surprised the linter hasn't caught this.

@ghost ghost assigned gabrielschulhof Nov 14, 2013
@gabrielschulhof
Copy link

I guess the minifier is helping us out by removing the superfluous comma, thereby rendering the source palatable for IE7 ...

gabrielschulhof pushed a commit that referenced this issue Nov 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.