Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Change to visibility:hidden instead of display none for inactive pages #8137

Closed
jaspermdegroot opened this issue May 21, 2015 · 3 comments
Closed

Change to visibility:hidden instead of display none for inactive pages #8137

jaspermdegroot opened this issue May 21, 2015 · 3 comments
Assignees
@arschmitz @apsdehal
Labels
Status: Has PR
Milestone
1.5.0

Comments

@jaspermdegroot
Copy link
Contributor

No description provided.

@jaspermdegroot jaspermdegroot self-assigned this May 21, 2015
@jaspermdegroot jaspermdegroot changed the title Investigate using visibility hidden instead of display non for inactive pages May 21, 2015
@jaspermdegroot jaspermdegroot mentioned this issue Jul 23, 2015
Closed
@arschmitz
Copy link
Contributor

Something else to consider here is opacity:0 where as toggling display or visibility triggers a layout and repaint an opacity change only repaints that element. However elements with opacity:0 still receive events where as visibility:none do not. I cant think of a case where this would be an issue but something to keep in mind.
@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Jul 23, 2015
@jaspermdegroot jaspermdegroot changed the title Investigate using visibility hidden instead of display none for inactive pages Jul 26, 2015
@jaspermdegroot
Copy link
Contributor Author

PR: #8241
arschmitz added a commit that referenced this issue Jul 30, 2015
@arschmitz
Page: Use visibility:hidden instead of display:none to hide page
40a33cf 
Avoiding display: none means we can calculate heights before transitions
This means less visual update after the end of the transition
and removes the need for binding to pageshow for page layout updates
this also has a small performance benefit since it avoids reflows

Closes gh-8241
Fixes gh-8137
@arschmitz
Copy link
Contributor

switching this to be for using visibility:hidden we cant use opacity because things in inactive pages will still be tabbable
@arschmitz arschmitz changed the title Change to opacity 0 instead of display none for inactive pages Jul 30, 2015
arschmitz added a commit that referenced this issue Mar 26, 2016
@arschmitz
Page: Use visibility:hidden instead of display:none to hide page
4af34df 
Avoiding display: none means we can calculate heights before transitions
This means less visual update after the end of the transition
and removes the need for binding to pageshow for page layout updates
this also has a small performance benefit since it avoids reflows

Closes gh-8241
Fixes gh-8137
@apsdehal apsdehal closed this as completed May 8, 2016
arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016
@arschmitz
Page: Use visibility:hidden instead of display:none to hide page
8cbf649 
Avoiding display: none means we can calculate heights before transitions
This means less visual update after the end of the transition
and removes the need for binding to pageshow for page layout updates
this also has a small performance benefit since it avoids reflows

Closes jquery-archivegh-8241
Fixes jquery-archivegh-8137
@apsdehal apsdehal self-assigned this Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Has PR
3 participants
@arschmitz @jaspermdegroot @apsdehal