Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

1.5-dev Panel: Toolbars don't transition together with content anymore #8324

Closed
jaspermdegroot opened this issue Nov 9, 2015 · 3 comments
Closed

1.5-dev Panel: Toolbars don't transition together with content anymore #8324

jaspermdegroot opened this issue Nov 9, 2015 · 3 comments
Assignees
@cgack
Labels
Component: Panel Priority: Blocker
Milestone
1.5.0

Comments

@jaspermdegroot
Copy link
Contributor

When opening/closing reveal and push panels, the header and footer don't transition together with the content anymore. I suppose this is because changes in the toolbar widget haven't been applied yet to the panel widget.

Test page: http://view.jquerymobile.com/1.5-dev/demos/panel/
@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Nov 9, 2015
@cgack
Copy link
Contributor

cgack commented Dec 17, 2015

making a note for my future self... these selectors should be changed here: https://github.com/jquery/jquery-mobile/blob/master/js/widgets/panel.js#L107-L124
@cgack
Copy link
Contributor

cgack commented Mar 3, 2016

It looks as though ui-toolbar-header isn't set by the time we are wrapping the content in ui-panel-wrapper, this is causing the headers to remain unwrapped. continuing to investigate
cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 8, 2016
@cgack
Panel: Transition with new toolbars
a897827 
Fixes jquery-archivegh-8324
@cgack cgack mentioned this issue Mar 8, 2016
Closed
cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 24, 2016
@cgack
Panel: Transition with new toolbars
ad3f5e5 
add mobile namespace

Fixes jquery-archivegh-8324
arschmitz pushed a commit that referenced this issue Mar 26, 2016
@cgack @arschmitz
Panel: Transition with new toolbars
57be65e 
Fixes gh-8324
@cgack
Copy link
Contributor

cgack commented May 19, 2016

Closed via gh-8397
@cgack cgack closed this as completed May 19, 2016
arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016
@cgack @arschmitz
Panel: Transition with new toolbars
cfef5c6 
Fixes jquery-archivegh-8324
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Panel Priority: Blocker
2 participants
@cgack @jaspermdegroot