Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Update Build info in README #8339

Closed
jaspermdegroot opened this issue Dec 3, 2015 · 13 comments
Closed

Update Build info in README #8339

jaspermdegroot opened this issue Dec 3, 2015 · 13 comments
Assignees

Comments

@jaspermdegroot
Copy link
Contributor

This information is outdated: https://github.com/jquery/jquery-mobile/tree/1.5-dev#buildcustomization Task "dist" doesn't exist anymore. Also have to check the other build tasks and the test tasks (https://github.com/jquery/jquery-mobile/tree/1.5-dev#testing).

@jaspermdegroot jaspermdegroot changed the title Update README Build info Dec 3, 2015
@marti1125
Copy link
Contributor

Hi! @jaspermdegroot how to I can help you with this?

@jaspermdegroot
Copy link
Contributor Author

Hi @marti1125

Thanks a lot for offering help!

In the "1.5-dev" branch the Grunt files have been split up in multiple files and tasks have been renamed.
The README.md file in that branch should be updated so it contains the right information about how to run tests, build demos, build framework JS and CSS files, etc..
Could you look into this and open a PR for it?

@marti1125
Copy link
Contributor

@jaspermdegroot sure :D

@marti1125
Copy link
Contributor

Hi @jaspermdegroot could you help with tests

  • grunt test --suites=button,slider (buttons doesn't appear in console)
  • grunt test --suites=button (Aborted due to warnings.)
  • grunt test --type=integration --suites=!navigation (doesn't work....)
  • I'm using grunt build:js insteand of grunt js because Error: Task "js" not found.

List of task
https://gist.github.com/marti1125/91ef6af42d76362d71c9

@jaspermdegroot
Copy link
Contributor Author

@arschmitz - Can you help @marti1125 with this since you made the changes in the Grunt tasks? Thanks!

@arschmitz
Copy link
Contributor

@marti1125 the current tasks are listed here https://github.com/jquery/jquery-mobile/blob/1.5-dev/build/tasks/alias.js

there is no longer a button suite because this is now pulled in from jQuery UI and its tests live there.

If you need anything explained with the aliases we have set up just let me know

@marti1125
Copy link
Contributor

@arschmitz Thanks
How to know what parameter can I pass into grunt task

  • grunt test
  • THEME=my-theme grunt css

@arschmitz @jaspermdegroot
Is it okay if I change grunt build:js instead of grunt js?

https://github.com/jquery/jquery-mobile/blob/1.5-dev/build/tasks/alias.js#L24

@arschmitz
Copy link
Contributor

@marti1125 the correct new task is grunt build:js

as far as parameters i don't think those have changed for equivalent tasks

@marti1125
Copy link
Contributor

cool! I'm going to update the README

@marti1125
Copy link
Contributor

@arschmitz
about: grunt test --type=integration --suites=!navigation
-bash: !navigation: event not found

@marti1125
Copy link
Contributor

any update about this =)

@apsdehal
Copy link
Contributor

apsdehal commented Apr 1, 2016

@marti1125 This has been merged into 1.5-dev, closing accordingly.

@apsdehal apsdehal closed this as completed Apr 1, 2016
@marti1125
Copy link
Contributor

ok :)

arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016
arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016
@apsdehal apsdehal self-assigned this Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants