Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Selectmenu: checkboxes in multiple select menu list are missing #8507

Open
jaspermdegroot opened this issue Aug 31, 2016 · 4 comments
Open

Selectmenu: checkboxes in multiple select menu list are missing #8507

jaspermdegroot opened this issue Aug 31, 2016 · 4 comments
Assignees
@apsdehal
Labels
Action: PR needs reviewing Component: Selectmenu Priority: Blocker Status: Has PR
Milestone
1.5.0

Comments

@jaspermdegroot
Copy link
Contributor

jaspermdegroot commented Aug 31, 2016 •
edited
Loading

Checkboxes in multiple select menu list are missing.

See the "multiple" examples on http://view.jquerymobile.com/master/demos/selectmenu-custom/ vs. http://demos.jquerymobile.com/1.4.5/selectmenu-custom/
@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Aug 31, 2016
@apsdehal apsdehal self-assigned this Sep 22, 2016
@apsdehal
Copy link
Contributor

@jaspermdegroot Any particular reason these were removed in bf6bb09
@jaspermdegroot
Copy link
Contributor Author

@apsdehal - That was because we are switching from ::after pseudo element to spans for icons.
@apsdehal
Copy link
Contributor

So checkbox was generated by the pseudo element which is no longer available. Thus, to solve this I have to add span element in anchor with proper classes.
@jaspermdegroot
Copy link
Contributor Author

@apsdehal - Yeah, that's correct.
apsdehal added a commit that referenced this issue Sep 29, 2016
@apsdehal
Select: Show missing checkbox in multiple select
0716afb 
Fixes #8507
Closes #8525
@apsdehal apsdehal mentioned this issue Sep 29, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Action: PR needs reviewing Component: Selectmenu Priority: Blocker Status: Has PR
2 participants
@jaspermdegroot @apsdehal