Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -ms-filter calculations for jQuery UI 1.13 #612

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 21, 2024

Note: only review the latest commit; the rest #611. Test failures will disappear once #608 lands and this PR is rebased; this shouldn't be a blocker to reviewing this PR.

jQuery UI 1.13 uses -ms-filter which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190

@mgol mgol requested review from fnagel and timmywil April 21, 2024 10:00
@mgol mgol self-assigned this Apr 21, 2024
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

jQuery UI 1.13 uses `-ms-filter` which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190
@mgol mgol merged commit df71103 into jquery:main Apr 21, 2024
3 checks passed
@mgol mgol deleted the ms-filter-fix branch April 21, 2024 20:51
@mgol mgol removed the Needs review label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants