Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm modules #103

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Update npm modules #103

merged 1 commit into from
Oct 24, 2016

Conversation

leobalter
Copy link
Member

No description provided.

leobalter added a commit to leobalter/jquery-color that referenced this pull request Mar 21, 2016
@raphamorim raphamorim mentioned this pull request Apr 14, 2016
@mgol
Copy link
Member

mgol commented May 22, 2016

Looks good, though it'd be nice to have coverage state tracked in CI.

@leobalter
Copy link
Member Author

it'd be nice to have coverage state tracked in CI.

it's currently only reported on Travis, but we can add it later with any other tool like Coveralls or manually.

Can we do this on a follow up PR?

leobalter added a commit to leobalter/jquery-color that referenced this pull request May 30, 2016
@leobalter
Copy link
Member Author

the branch is rebased to remove conflicts, no changes were made in the contents of this PR.

@leobalter
Copy link
Member Author

Apparently browserstack is failing for PRs but still passing on master.

...

@mgol
Copy link
Member

mgol commented Jun 1, 2016

This looks good then once CI is fixed for PRs.

@leobalter
Copy link
Member Author

I removed the coverage part as grunt-qunit-istanbul is triggering a failure on Mac OS Sierra, I need to update this module.

I'll fix the CI run and get this up to date

@leobalter leobalter merged commit 8444bc8 into jquery:master Oct 24, 2016
@leobalter leobalter changed the title Update npm modules and add Coverage Oct 24, 2016
@leobalter leobalter mentioned this pull request Oct 24, 2016
@mgol mgol added this to the 3.0.0 milestone May 6, 2020
@mgol mgol added the build label May 6, 2020
@mgol mgol modified the milestones: 3.0.0, 2.2.0 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants