Skip to content

Commit

Permalink
Datepicker: Get selectedDay from data-date instead of element contents
Browse files Browse the repository at this point in the history
This makes datepicker work fine even if translation software modifies texts on the page.

Closes gh-1943
  • Loading branch information
c-lambert committed Jul 12, 2021
1 parent 70dae67 commit cf938e2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ui/widgets/datepicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ $.extend( Datepicker.prototype, {
}

inst = this._getInst( target[ 0 ] );
inst.selectedDay = inst.currentDay = $( "a", td ).html();
inst.selectedDay = inst.currentDay = parseInt( $( "a", td ).attr( "data-date" ) );
inst.selectedMonth = inst.currentMonth = month;
inst.selectedYear = inst.currentYear = year;
this._selectDate( id, this._formatDate( inst,
Expand Down Expand Up @@ -1932,6 +1932,7 @@ $.extend( Datepicker.prototype, {
( printDate.getTime() === currentDate.getTime() ? " ui-state-active" : "" ) + // highlight selected day
( otherMonth ? " ui-priority-secondary" : "" ) + // distinguish dates from other months
"' href='#' aria-current='" + ( printDate.getTime() === currentDate.getTime() ? "true" : "false" ) + // mark date as selected for screen reader
"' data-date='" + printDate.getDate() + // store date as data
"'>" + printDate.getDate() + "</a>" ) ) + "</td>"; // display selectable date
printDate.setDate( printDate.getDate() + 1 );
printDate = this._daylightSavingAdjust( printDate );
Expand Down

0 comments on commit cf938e2

Please sign in to comment.