Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion: correct height calculated when closed #1536

Closed
wants to merge 5 commits into from
+38 −1
Closed

Accordion: correct height calculated when closed #1536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb7bb7b
Accordion: correct height calculated when closed
apushak Apr 13, 2015
6a36202
Accordion: correct height calculated when closed
apushak Apr 21, 2015
693c9a5
Accordian: correct height calculated when closed
apushak Apr 22, 2015
9b720f8
Accordion: unit test for collapsed height
apushak Apr 23, 2015
46e065e
Accordion: unit test for collapsed height
apushak Apr 24, 2015
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Accordion: unit test for collapsed height 
Ref  #11938
  • Loading branch information
@apushak
apushak committed Apr 24, 2015
commit 46e065ea6453c1b88b84a377f590341fa1d57dbc
12 changes: 0 additions & 12 deletions tests/unit/accordion/methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,6 @@ var equalHeight = testHelper.equalHeight,

module( "accordion: methods", setupTeardown() );

test( "collapsedHeight", function() {
expect( 1 );
var element = $( "#collapsible" ).accordion(),
content = element.find( ".ui-accordion-content" ),
height = content.height();
element.accordion( "destroy" ).accordion({
active: false,
collapsible: true
});
equal( content.height(), height );
});

test( "destroy", function( assert ) {
expect( 1 );
assert.domEqual( "#list1", function() {
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/accordion/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,19 @@ test( "{ active: false }", function() {
strictEqual( element.accordion( "option", "active" ), 0 );
});

// http://bugs.jqueryui.com/ticket/11938
test( "{ active: false, collapsible: true }", function() {
expect( 1 );
var element = $( "#collapsible" ).accordion(),
content = element.find( ".ui-accordion-content" ),
height = content.height();
element.accordion( "destroy" ).accordion({
active: false,
collapsible: true
});
equal( content.height(), height );
});

test( "{ active: Number }", function() {
expect( 8 );
var element = $( "#list1" ).accordion({
Expand Down