Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable: Setting table row placeholder height to be same as sorted row #1578

Closed
wants to merge 1 commit into from
Closed

Sortable: Setting table row placeholder height to be same as sorted row #1578

wants to merge 1 commit into from

Conversation

kevincupp
Copy link
Contributor

jQuery ticket: http://bugs.jqueryui.com/ticket/13662

Past history that led to the issue: bd47bd4 9711c54

Here is my proposed fix. It was difficult coming up with a solution that would mostly preserve previous behavior while also fixing this, but I ultimately ended up using the forcePlaceholderSize config. My thinking was if you've set that, any CSS you've hoped would apply to table row height wouldn't matter and we could safely set an inline height.
@kevincupp
Copy link
Contributor Author

I should note also another option is to go back to the pre-1.10 behavior of setting an inline height on placeholder table rows anyway. If folks don't want it, they can set a placeholder class. I'd prefer this, but recognized it would change current behavior slightly and may not always be preferable.
@kevincupp kevincupp deleted the bug/table-row-placeholder-height branch October 5, 2016 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@kevincupp @jquerybot