Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion: Correct height calculated when closed #1616

Closed
wants to merge 1 commit into from
Closed

Accordion: Correct height calculated when closed #1616

wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Fixes #11938
Closes gh-1536

This is just the code form gh-1536 squashed, rebased, and updated to the new style guide. It's passing locally for me, so I want to see if it will pass on Travis.
@scottgonzalez
Copy link
Member Author

Well that didn't work. I even changed Travis to use container based infrastructure and switched to node 0.12. I have no idea what else we can try to make Travis pass.
@jzaefferer
Copy link
Member

We need an evergreen headless browser that actually works. At this point we have to consider just not running any tests against PhantomJS.
scottgonzalez pushed a commit that referenced this pull request Jun 9, 2016
@apushak @scottgonzalez
Accordion: Correct height calculated when closed
00e5e14 
Fixes #11938
Closes gh-1536
Closes gh-1616

(cherry picked from commit c87653b)
@scottgonzalez scottgonzalez deleted the pr-1536 branch July 7, 2016 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@scottgonzalez @jzaefferer @jquerybot @apushak