Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable: fix wrong initial helper position in scrolled container (#15021) #1749

Closed
wants to merge 5 commits into from
Closed

Sortable: fix wrong initial helper position in scrolled container (#15021) #1749

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74bb41b
fix for #15021
typytype Sep 23, 2016
1ae0bb8
fix whitespace
typytype Sep 23, 2016
e53ce4c
Update sortable.js
typytype Oct 3, 2016
26f30b3
Update sortable.js
typytype Oct 3, 2016
fc6c7f7
Update sortable.js
typytype Oct 3, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix whitespace
  • Loading branch information
@typytype
typytype committed Sep 23, 2016
commit 1ae0bb88d3428b1ad25fe995797f6cf6785195d8
2 changes: 1 addition & 1 deletion ui/widgets/sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ return $.widget( "ui.sortable", $.ui.mouse, {
top: this.offset.top - this.margins.top,
left: this.offset.left - this.margins.left
};

// Only after we got the offset, we can change the helper's position to absolute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is now wrong.
// TODO: Still need to figure out a way to make relative sorting possible
this.helper.css( "position", "absolute" );
Expand Down