Theme fixes #1753
Closed
Theme fixes #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more semanticly correct then fcActive and looks the same or better on most themes Fixes jquery/download.jqueryui.com#335
|
Diff looks good to me. |
|
This now also fixes https://bugs.jqueryui.com/ticket/15059. |
| @@ -119,7 +119,7 @@ a.ui-button:active, | |||
| .ui-icon-background, | |||
| .ui-state-active .ui-icon-background { | |||
| border: #003eff/*{borderColorActive}*/; | |||
| background-color: #ffffff/*{fcActive}*/; | |||
| background-color: #ffffff/*{bgColorContent}*/; | |||
There was a problem hiding this comment.
Why are we pairing the content background with the active border? Why is this not using the active background?
There was a problem hiding this comment.
The active background does not look good at all in the majority of themes. We can switch the border color to match though.
There was a problem hiding this comment.
Ok. I think it makes sense for these to match. Though it's a shame the active colors don't work here.
mgol
added a commit
that referenced
this pull request
Sep 25, 2021
) * Revert "Theme: Removes css for ui-state-checked its not used any more" This reverts commit 1b0e947. * Revert "Theme: Replace missing definition for default icons" This reverts commit dde9b83. * Revert "Theme: Switch icon background to use bgColorContent" This reverts commit 265b8f5. This reverts three commits: * Theme: Removes css for ui-state-checked its not used any more 1b0e947 (#1753) * Theme: Replace missing definition for default icons dde9b83 * Theme: Switch icon background to use bgColorContent 265b8f5 which caused styling issues when compared to UI 1.12.1. This unfixes a few issues: * jquery/download.jqueryui.com#335 * https://bugs.jqueryui.com/ticket/15059 * https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016 However, old & known issues are better than new & unknown ones, especially with our current very limited resources. Closes gh-1983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jquery/download.jqueryui.com#335
Ref https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016