-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sortable Fix-Up #1793
Closed
Closed
Sortable Fix-Up #1793
Commits on Feb 16, 2017
-
* Created _scroll extension point and migrated scroll code from _mouseDrag * Cleaned up logic for scrolled * Fixed appendTo functionality to match documentation * Remove unnecessary function calls * Move set-up position functions to appropriate place * Base scrollParent on placeholder and not helper * Update scrollParent when switching containers
Configuration menu - View commit details
-
Copy full SHA for aa9de1a - Browse repository at this point
Copy the full SHA aa9de1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b34513 - Browse repository at this point
Copy the full SHA 8b34513View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01cc678 - Browse repository at this point
Copy the full SHA 01cc678View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa92211 - Browse repository at this point
Copy the full SHA aa92211View commit details -
* Removed scrollParent placeholder basis due to unknown difference between local copy and pushed copy functionality
Configuration menu - View commit details
-
Copy full SHA for 481c37f - Browse repository at this point
Copy the full SHA 481c37fView commit details -
* Fixed merge issue with position of _getParentOffset() and reinstated scrollParent based on placeholder
Configuration menu - View commit details
-
Copy full SHA for 64d7655 - Browse repository at this point
Copy the full SHA 64d7655View commit details
Commits on Feb 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 35215a8 - Browse repository at this point
Copy the full SHA 35215a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 764b6b2 - Browse repository at this point
Copy the full SHA 764b6b2View commit details
Commits on Feb 18, 2017
-
* Update offset as well when moving from sortable with no scrollbar to a sortable with scroll bar * No need to process mouse drag if not in a container
Configuration menu - View commit details
-
Copy full SHA for 93f77d9 - Browse repository at this point
Copy the full SHA 93f77d9View commit details -
* Missing update of absolute position left component via scroll action
Configuration menu - View commit details
-
Copy full SHA for a8c660d - Browse repository at this point
Copy the full SHA a8c660dView commit details
Commits on Feb 20, 2017
-
* Scroll values were slightly different from offset values for items so reverted to using offset to update item positions after scroll * Created entry for dragDirection to reduce superflous function calls * Removed unneeded code give fix-up for offsetParent
Configuration menu - View commit details
-
Copy full SHA for 5c4becc - Browse repository at this point
Copy the full SHA 5c4beccView commit details
Commits on Feb 21, 2017
-
* Worked refreshItemPositions function into existing refreshPosition function
Configuration menu - View commit details
-
Copy full SHA for d76014e - Browse repository at this point
Copy the full SHA d76014eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.