Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: Ignore mouse events triggered due to page scrolling #1806

Closed
wants to merge 3 commits into from
Closed

Menu: Ignore mouse events triggered due to page scrolling #1806

wants to merge 3 commits into from

Conversation

scottgonzalez
Copy link
Member

Fixes #9356
@jsf-clabot
Copy link

jsf-clabot commented Apr 18, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
scottgonzalez
scottgonzalez commented Apr 19, 2017
View reviewed changes
tests/unit/selectmenu/core.js
@@ -251,13 +251,13 @@ $.each( [
wrappers = menu.find( "li.ui-menu-item .ui-menu-item-wrapper" );

button.trigger( "click" );
wrappers.first().simulate( "mouseover" ).trigger( "click" );
wrappers.first().simulate( "mouseover", { clientX: 2, clientY: 2 } ).trigger( "click" );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hacky, but simulate doesn't fill in realistic values for anything other than drag. We should update simulate and remove this, but that seemed a little out of scope for this PR.
@scottgonzalez scottgonzalez deleted the menu-scroll-mouse branch May 2, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@scottgonzalez @jsf-clabot