Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable: fix element position #1859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sortable: fix element position #1859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Sortable: fix element position 
Fixes #15274
  • Loading branch information
@krzysztof-grzybek
krzysztof-grzybek committed Apr 24, 2018
commit 4965ad98dbf5b9098e0d5ec3de99e58e785521f9
9 changes: 7 additions & 2 deletions ui/widgets/sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,6 +1177,12 @@ return $.widget( "ui.sortable", $.ui.mouse, {
//Get the offsetParent and cache its position
this.offsetParent = this.helper.offsetParent();
var po = this.offsetParent.offset();
var scroll = this.cssPosition === "absolute" &&
!( this.scrollParent[ 0 ] !== this.document[ 0 ] &&
$.contains( this.scrollParent[ 0 ], this.offsetParent[ 0 ] ) ) ?
this.offsetParent :
this.scrollParent,
scrollIsRootNode = ( /(html|body)/i ).test( scroll[ 0 ].tagName );

// This is a special case where we need to modify a offset calculated on start, since the
// following happened:
Expand All @@ -1185,8 +1191,7 @@ return $.widget( "ui.sortable", $.ui.mouse, {
// 2. The actual offset parent is a child of the scroll parent, and the scroll parent isn't
// the document, which means that the scroll is included in the initial calculation of the
// offset of the parent, and never recalculated upon drag
if ( this.cssPosition === "absolute" && this.scrollParent[ 0 ] !== this.document[ 0 ] &&
$.contains( this.scrollParent[ 0 ], this.offsetParent[ 0 ] ) ) {
if ( !scrollIsRootNode ) {
po.left += this.scrollParent.scrollLeft();
po.top += this.scrollParent.scrollTop();
}
Expand Down