Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Account for an extra noop focus/blur listener in jQuery >=3.4 #1945

Merged
merged 1 commit into from
Feb 20, 2021

Commits on Feb 19, 2021

  1. Tests: Account for an extra noop focus/blur listener in jQuery >=3.4

    jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various
    issues with checkboxes/radio buttons as well as being able to pass data in focus
    triggers. This leaves extra focus & blur events if any of these events were ever
    listened to at a particular element.
    
    We've started skipping these handlers in the `domEqual` assertion in jquerygh-1930 but
    we missed a case where an event is triggered before any handler is attached -
    jQuery >=3.4.0 attaches then an extra noop listener just to force the code path
    to go through the setup code before the trigger happens. We now skip this extra
    handler as well.
    
    This fixes a test failure in "dialog: methods" destroy tests.
    
    Ref jquery/jquery#4496
    Ref jquerygh-1930
    mgol committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    e5208e9 View commit details
    Browse the repository at this point in the history