Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Don't save temporary npm dependencies to package.json, update release deps #1966

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

mgol
Copy link
Member

@mgol mgol commented Aug 5, 2021

Past npm versions required the --save flag to save anything in package.json
when installing packages but newer ones do this by default. Pass --no-save to
restore the original behavior in the release-test.js script.

Also, update release dependencies for the 1.13 release.

@mgol mgol added this to the 1.13.0 milestone Aug 5, 2021
@mgol mgol requested a review from fnagel August 5, 2021 14:36
@mgol mgol self-assigned this Aug 5, 2021
@mgol
Copy link
Member Author

mgol commented Aug 5, 2021

Before merging this, merge jquery/download.jqueryui.com#582 & release a new version of the download.jqueryui.com package.

Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

Past npm versions required the `--save` flag to save anything in `package.json`
when installing packages but newer ones do this by default. Pass `--no-save` to
restore the original behavior in the `release-test.js` script.

Ref jquerygh-1966
@mgol mgol merged commit 202238b into jquery:main Aug 6, 2021
@mgol mgol deleted the jquery-release-fixes branch August 6, 2021 11:36
mgol added a commit that referenced this pull request Aug 6, 2021
Past npm versions required the `--save` flag to save anything in `package.json`
when installing packages but newer ones do this by default. Pass `--no-save` to
restore the original behavior in the `release-test.js` script.

Ref gh-1966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants