Sortable: Fix positioning when moving a Draggable item into a Sortable #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borgboyone I hope restoring this is safe but I can only guess as I can't know why you removed it in #1793. If you could say if it seems safe to restore to you, that'd be great! |
fnagel
approved these changes
Nov 8, 2021
PR jquerygh-1793 removed setting `this.offset.parent` in the Draggable `refreshPositions` method which broke position calculations when moving a Draggable item into a connected Sortable. restore that assignment. Ref jquerygh-1793 Fixes jquerygh-2001
mgol
force-pushed
the
sortable-draggable-offset-gh-2001
branch
from
6de3848
to
2fb8097
Compare
|
jQuery UI 1.13.1 including this fix has been released: https://blog.jqueryui.com/2022/01/jquery-ui-1-13-1-released/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR gh-1793 removed setting
this.offset.parentin the DraggablerefreshPositionsmethod which broke position calculations when movinga Draggable item into a connected Sortable. restore that assignment.
Ref gh-1793
Fixes gh-2001