Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FontAwesome font with SVG icons #455

Open
2 of 5 tasks
Krinkle opened this issue Apr 10, 2024 · 0 comments
Open
2 of 5 tasks

Replace FontAwesome font with SVG icons #455

Krinkle opened this issue Apr 10, 2024 · 0 comments
Assignees
@Krinkle
Labels
Type: Improvement

Comments

@Krinkle
Copy link
Member

Krinkle commented Apr 10, 2024 •
edited
Loading

I tried this for the footer icons as part of 28542b5 and that seemed to work quite well. We only use a handful of the icons, and so rather than loading a 23KB font file, we can load a handful of SVG icons. This would also make updates easier as right now it feels a bit scary to change this since it's one file for everything and it's unclear which ones we actually need.

Proposed outline:

  • Remove unused icon- utility classes, based on GitHub org-wide search for the class name (excluding false positives, such as from archived repos, and repos containing content that isn't themed by wordpress, such as web-event, irc.jquery.org and bugs.jquery.com, and demos.jquerymobile.com).
  • Reduce icon class definitions to only those that are used.
  • Replace one icon- with an SVG version.
  • Replace the rest
  • Remove FontAwesome from repo.
@Krinkle Krinkle self-assigned this Apr 10, 2024
Krinkle added a commit that referenced this issue Apr 10, 2024
@Krinkle
All: remove unused FontAwesome utilities classes
7fa8250 
* icon-muted
* icon-border
* icon-2x
* icon-3x
* icon-4x
* icon-spin

These appear to be unused, according to an org-wide search on GitHub,
excluding matches in repos that don't use jquery-wp-content for their
content (e.g. irc.jquery.org, bugs.jquery.com, and archived content
repos such as web-events).

Ref #455.
@Krinkle Krinkle mentioned this issue Apr 10, 2024
Merged
Krinkle added a commit that referenced this issue Apr 10, 2024
@Krinkle
All: remove unused FontAwesome utilities classes
0d0da15 
* icon-muted
* icon-border
* icon-2x
* icon-3x
* icon-4x
* icon-spin

These appear to be unused, according to an org-wide search on GitHub,
excluding matches in repos that don't use jquery-wp-content for their
content (e.g. irc.jquery.org, bugs.jquery.com, and archived content
repos such as web-events).

Ref #455.
Krinkle added a commit that referenced this issue Apr 12, 2024
@Krinkle
All: remove various unused FontAwesome icons
216c29c 
utility:
* icon-white

Ref https://github.com/search?q=org%3Ajquery+icon-white+NOT+repo%3Ajquery%2Fevents.jquery.org+NOT+repo%3Ajquery%2Fblog.jquery.com-theme+NOT+repo%3Ajquery%2Fweb-events+NOT+repo%3Ajquery%2Ftestswarm&type=code

more icons, via more complex search to exclude false positive matches
for `ui-icon-*` classes:

Ref https://github.com/search?q=org%3Ajquery+NOT+repo%3Ajquery%2Fevents.jquery.org+NOT+repo%3Ajquery%2Fblog.jquery.com-theme+NOT+repo%3Ajquery%2Fweb-events+NOT+repo%3Ajquery%2Ftestswarm+NOT+repo%3Ajquery%2Fcla-archive+NOT+repo%3Ajquery%2Firc.jquery.org+NOT+repo%3Ajquery%2Fbugs.jquery.com+NOT+repo%3Ajquery%2Fdemos.jquerymobile.com+%2F%5B%5E-%5Dicon-search%2F&type=code

Ref #455
Krinkle added a commit that referenced this issue Apr 17, 2024
@Krinkle
All: Update license URL, clarify icon class usage
e99501d 
Ref #455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement
1 participant
@Krinkle