Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make changes to comments/order in the default theme in the JQM repo (if needed) #150

Closed
jaspermdegroot opened this issue Nov 22, 2013 · 2 comments
Closed

Make changes to comments/order in the default theme in the JQM repo (if needed) #150

jaspermdegroot opened this issue Nov 22, 2013 · 2 comments
Milestone
1.4.0

Comments

@jaspermdegroot
Copy link
Member

One example is that in app.js there is a regex that looks for /* Structure */. In <= 1.3 this comment came after the swatches, but in 1.4 it's no longer in the default theme. So we might have to put that comment in there again. (Actually it are global styles and not structure CSS that follows after that comment, but this is not relevant)

Another thing is that in 1.4 the default theme doesn't start with swatches, but with some global rules. After the swatches there a few more global rules.
@jaspermdegroot
Copy link
Member Author

If we make changes in the default theme we also have to update the classic theme demo.
@jaspermdegroot
Copy link
Member Author

/*{global-icon-disc-alt}*/ needs to be removed
gabrielschulhof pushed a commit that referenced this issue Nov 25, 2013
1.4 default and starter theme: Remove /*{global-icon-disc-alt}*/. Re: #…
665a177 
…150, Fixes #152 - Javascript error when moving from 1.3.2 to 1.4.0-beta.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@jaspermdegroot