Changed minimum deployment target to iOS 12.0 (was 13.0) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for bringing this to my attention! It does sound like we can reduce the minimum target to 12. I'll make an issue out of this, do a bit of testing on my end, and make the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wave currently does not appear to require iOS 13 APIs. I integrated this change in an app with a minimum deployment target of iOS 12 and tested it on an iPhone 5s running iOS 12.5.5, using both the block-based and the property-based API, and found no issue.
Allowing iOS 12 instead of 13 means that client apps don't need to make the following models prematurely obsolete: iPhone 5s, iPod touch 6th generation, iPad mini 2, iPad mini 3, iPad Air, 9.7-inch iPad 6th generation.