Skip to content

Commit

Permalink
chore: use strings.ReplaceAll (#3801)
Browse files Browse the repository at this point in the history
  • Loading branch information
hezhizhen committed May 18, 2024
1 parent 0994d9c commit 01e7668
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions src/ansi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ func TestAnsiCodeStringConversion(t *testing.T) {
state := interpretCode(code, prevState)
if expected != state.ToString() {
t.Errorf("expected: %s, actual: %s",
strings.Replace(expected, "\x1b[", "\\x1b[", -1),
strings.Replace(state.ToString(), "\x1b[", "\\x1b[", -1))
strings.ReplaceAll(expected, "\x1b[", "\\x1b["),
strings.ReplaceAll(state.ToString(), "\x1b[", "\\x1b["))
}
}
assert("\x1b[m", nil, "")
Expand Down
8 changes: 4 additions & 4 deletions src/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ func splitNth(str string) ([]Range, error) {

func delimiterRegexp(str string) Delimiter {
// Special handling of \t
str = strings.Replace(str, "\\t", "\t", -1)
str = strings.ReplaceAll(str, "\\t", "\t")

// 1. Pattern does not contain any special character
if regexp.QuoteMeta(str) == str {
Expand Down Expand Up @@ -1132,9 +1132,9 @@ Loop:
masked += strings.Repeat(" ", loc[1])
action = action[loc[1]:]
}
masked = strings.Replace(masked, "::", string([]rune{escapedColon, ':'}), -1)
masked = strings.Replace(masked, ",:", string([]rune{escapedComma, ':'}), -1)
masked = strings.Replace(masked, "+:", string([]rune{escapedPlus, ':'}), -1)
masked = strings.ReplaceAll(masked, "::", string([]rune{escapedColon, ':'}))
masked = strings.ReplaceAll(masked, ",:", string([]rune{escapedComma, ':'}))
masked = strings.ReplaceAll(masked, "+:", string([]rune{escapedPlus, ':'}))
return masked
}

Expand Down
4 changes: 2 additions & 2 deletions src/pattern.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,14 @@ func BuildPattern(cache *ChunkCache, patternCache map[string]*Pattern, fuzzy boo
}

func parseTerms(fuzzy bool, caseMode Case, normalize bool, str string) []termSet {
str = strings.Replace(str, "\\ ", "\t", -1)
str = strings.ReplaceAll(str, "\\ ", "\t")
tokens := _splitRegex.Split(str, -1)
sets := []termSet{}
set := termSet{}
switchSet := false
afterBar := false
for _, token := range tokens {
typ, inv, text := termFuzzy, false, strings.Replace(token, "\t", " ", -1)
typ, inv, text := termFuzzy, false, strings.ReplaceAll(token, "\t", " ")
lowerText := strings.ToLower(text)
caseSensitive := caseMode == CaseRespect ||
caseMode == CaseSmart && text != lowerText
Expand Down
2 changes: 1 addition & 1 deletion src/terminal.go
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ func defaultKeymap() map[tui.Event][]*action {
}

func trimQuery(query string) []rune {
return []rune(strings.Replace(query, "\t", " ", -1))
return []rune(strings.ReplaceAll(query, "\t", " "))
}

func mayTriggerPreview(opts *Options) bool {
Expand Down
2 changes: 1 addition & 1 deletion src/tui/light.go
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ func (w *LightWindow) Print(text string) {
}

func cleanse(str string) string {
return strings.Replace(str, "\x1b", "", -1)
return strings.ReplaceAll(str, "\x1b", "")
}

func (w *LightWindow) CPrint(pair ColorPair, text string) {
Expand Down
6 changes: 3 additions & 3 deletions src/util/util_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,10 @@ func (x *Executor) QuoteEntry(entry string) string {
*/
return escapeArg(entry)
case shellTypePowerShell:
escaped := strings.Replace(entry, `"`, `\"`, -1)
return "'" + strings.Replace(escaped, "'", "''", -1) + "'"
escaped := strings.ReplaceAll(entry, `"`, `\"`)
return "'" + strings.ReplaceAll(escaped, "'", "''") + "'"
default:
return "'" + strings.Replace(entry, "'", "'\\''", -1) + "'"
return "'" + strings.ReplaceAll(entry, "'", "'\\''") + "'"
}
}

Expand Down

0 comments on commit 01e7668

Please sign in to comment.