Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A key should be able to contain dot #21

Merged
merged 1 commit into from
Sep 3, 2019
Merged

A key should be able to contain dot #21

merged 1 commit into from
Sep 3, 2019

Conversation

luoxiu
Copy link
Contributor

@luoxiu luoxiu commented Sep 3, 2019

  1. stringKey 没有 dot，fast path -> 提前返回。
  2. stringKey 有 dot:
    2.1. 有对应的值，返回该值。
    2.2. 没有对应的值，继续原来的 slow path。
@luoxiu
Copy link
Contributor Author

luoxiu commented Sep 3, 2019

BTW, I'm a huge fan of you, @CoderMJLee . ❤️
@CoderMJLee CoderMJLee merged commit 1dd6297 into kakaopensource:master Sep 3, 2019
@CoderMJLee
Copy link
Collaborator

3Q.
@luoxiu luoxiu deleted the key-contains-dots branch September 4, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@luoxiu @CoderMJLee