Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[big pr]: refactor project structure #27

Merged
merged 11 commits into from
Sep 6, 2019

Conversation

luoxiu
Copy link
Contributor

@luoxiu luoxiu commented Sep 5, 2019

resolve #26
Big pr,但大部分修改是移动文件。

这个 pr 主要修改了:

  1. 使用了 SwiftPM 生成的 project 模版。
  2. Carthage 现在支持了 macOS/tvOS/watchOS。
  3. Package.swift 添加了 test target,现在可以使用 swift test 快速测试了。
  4. Expose allTests to linux.
  5. 添加了 .travis.yml,现在 matrix 有 mac, iphone, appletv.

KakaJSON 的依赖只有 Foundation,支持 Linux 应该是顺理成章的,但这行代码在 Cocoa 上通过了编译,在 Linux 上却编译失败:

extension NSObject {
    static func newConvertible() -> Convertible {
        return self.init() as! Convertible  // Error: constructing an object of class type 'NSObject' with a metatype value must use a 'required' initializerinitializer
    }
}

所以暂时把 travis 里的 Linux 注释掉了。

@luoxiu
Copy link
Contributor Author

luoxiu commented Sep 5, 2019

New project structure:
project-structure

@CoderMJLee CoderMJLee merged commit 07cdb01 into kakaopensource:master Sep 6, 2019
@luoxiu luoxiu deleted the refactor-project-structure branch September 6, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants