fix(FEC-14000): Decoupling Plugins from Audio Player #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
JonathanTGold
commented
Jun 27, 2024
added 2 commits
July 18, 2024 13:30
semarche-kaltura
approved these changes
Jul 18, 2024
JonathanTGold
added a commit
to kaltura/playkit-js-downloads
that referenced
this pull request
Jul 18, 2024
#56) 1. remove flavors filter preventing audio files from being displayed 2. display an audio icon for audio files 3. display language as a description (instead of bitrate in video files) in audio files Resolves [FEC-14000](https://kaltura.atlassian.net/browse/FEC-14000), FEC-13915 FEC-13939 Related pr: kaltura/kaltura-player-js#805 kaltura/playkit-js-audio-player#27 kaltura/playkit-js-share#50 kaltura/playkit-js-transcript#205 [FEC-14000]: https://kaltura.atlassian.net/browse/FEC-14000?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
JonathanTGold
added a commit
to kaltura/playkit-js-share
that referenced
this pull request
Jul 18, 2024
### Description of the Changes Decoupling Plugins from Audio Player Related pr: kaltura/kaltura-player-js#805 kaltura/playkit-js-audio-player#27 kaltura/playkit-js-downloads#56 kaltura/playkit-js-transcript#205 --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
JonathanTGold
added a commit
to kaltura/playkit-js-transcript
that referenced
this pull request
Jul 18, 2024
Decoupling Plugins from Audio Player Related pr: kaltura/kaltura-player-js#805 kaltura/playkit-js-audio-player#27 kaltura/playkit-js-downloads#56 kaltura/playkit-js-share#50 --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
JonathanTGold
added a commit
to kaltura/playkit-js-audio-player
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Decoupling Plugins from Audio Player
Related pr:
kaltura/playkit-js-downloads#56
kaltura/playkit-js-share#50
kaltura/playkit-js-audio-player#27
kaltura/playkit-js-transcript#205