Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: DOMException in destroy #3641

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix: DOMException in destroy #3641

merged 1 commit into from
Apr 8, 2024

Conversation

wfk007
Copy link
Contributor

@wfk007 wfk007 commented Apr 8, 2024 •
edited
Loading

Short description

fix: #3637

Implementation details

  1. move new AbortController() from constructor to loadAudio
  2. add compatibility check for AbortController

How to test it

refer to: #3637

Screenshots

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes
katspaugh
katspaugh approved these changes Apr 8, 2024
View reviewed changes
Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense! An abort controller will now be created as many times as the fetch function is called, not just once and regardless of fetch.
@katspaugh
Copy link
Owner

Any chance you could add a test for destry + abort?
@wfk007
Copy link
Contributor Author

wfk007 commented Apr 8, 2024

Any chance you could add a test for destry + abort?

Yes, There have been a lot of things at work recently, I will take the time to add test cases later.
@katspaugh
Copy link
Owner

I'll merge this PR for now then, thank you!
@katspaugh katspaugh merged commit 1a97615 into katspaugh:main Apr 8, 2024
1 of 2 checks passed
@wfk007 wfk007 mentioned this pull request Apr 8, 2024
Merged
2 tasks
@ast2019 ast2019 mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@wfk007 @katspaugh