Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: expose setScroll api from render #3660

Merged
merged 1 commit into from
Apr 15, 2024
Merged

update: expose setScroll api from render #3660

merged 1 commit into from
Apr 15, 2024

Conversation

leyiang
Copy link
Contributor

@leyiang leyiang commented Apr 15, 2024

Short description

Resolves #3659

I didn't check pixels in setScroll because it's redundant, setting invalid value for scrollLeft will be set as left or right edge.
@leyiang
Copy link
Contributor Author

leyiang commented Apr 15, 2024

cypress test passed
katspaugh
katspaugh approved these changes Apr 15, 2024
View reviewed changes
Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!🙏
@katspaugh katspaugh merged commit 4cfde29 into katspaugh:main Apr 15, 2024
1 of 2 checks passed
@ast2019 ast2019 mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@leyiang @katspaugh