Feat: render canvases on scroll #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying wavesurfer-js with
|
| Latest commit: |
841a489
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f52b7a5e.wavesurfer-js.pages.dev |
| Branch Preview URL: | https://render-on-scroll.wavesurfer-js.pages.dev |
katspaugh
added a commit
that referenced
this pull request
May 18, 2024
This reverts commit 22d61c9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Resolves #3696
Instead of rendering the entire waveform asynchronously chunk by chunk, render only the chunks that are in the viewport.
Implementation details
We subscribe to the
scrollevent and render the parts of the waveform that are currently visible. If the number of canvases exceeds 100, we clear the old canvases.How to test it
It can be tested with this example: https://wavesurfer.xyz/examples/?d5da9feca7995cd70caabe1ce6ec18d4
Breaking API changes
The
redrawcompleteevent was previously emitted when all canvases finish rendering. Now it will be emitted after the initial 2 canvases are rendered.