Regions: allow overriding of css styles of region div and handle divs. #3749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Allows for general CSS overrides for regions and their handles.
While this allows for a wide range of customisations, my immediate use-cases for adding this were:
It's very possible I missed a way to do this with existing code. I'm also conscious that you might not want to allow arbitrary CSS overrides, in favour of more controlled options or custom HTML elements (as is done for the region content).
Implementation details
Added additional fields to region params which are overlayed onto CSS options for the relevant divs on creation.
How to test it
Specify custom overrides as part of region params and ensure they render.
Screenshots
wavesurferPatch.mov
Checklist
Sorry, no tests yet – if there's consensus this is a good approach I'll happily help put tests together. :)