Add mediaRecorderTimeslice option to RecordPluginOptions #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add mediaRecorderTimeslice option to RecordPluginOptions to which is passed to mediaRecorder.start(). - Add 'record-data-available' event which returns the blob that is delivered by the mediaRecorder and only that blob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
On Safari on both Mac and iOs, the audio generated by the record plugin cannot be properly processed by the OpenAI whisper model. This is a known issue that is addressed by passing a timeslice param of 1000 to the mediaRecorder.start() call.
Implementation details
If the optional
mediaRecorderTimeslicevalue is provided to the RecordPlugin initializer, the value is passed to themediaRecorder.start()call.How to test it
Pass a value of 1000 when running on any browser on iOS or in Safari on MacOS, recorded audio will be processed by OpenAI whisper. Without this value, only the first second or so of audio is correctly processed.
Screenshots
N/A
Checklist