chore: add trend image to readme #3769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cwtuan, I appreciate the contribution but I'm apprehensive of hot-linking an external image in the readme, especially given that your site has no privacy policy or terms of service. Nice idea though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and foremost, I'd like to extend my heartfelt thanks for creating and maintaining the wavesurfer.js package. I have created a pull request to add a dynamic NPM downloads trend image to the README file. This addition aims to visually demonstrate the growing popularity of wavesurfer.js over the years, which I believe will be valuable information for potential new users. Seeing a positive trend in downloads can instill confidence and encourage more developers to choose this library for their projects.
I look forward to your feedback.